Brenton Wiernik: "Ah, yep! This is done internally in aes(), so the only thing that’s needed to accommodate both spellings is export both versions of helper functions like scale_border_color_*() [ though I personally would just direct users to use scale_color_*(aesthetics = "border

Brenton Wiernik@bwiernik.bsky.social·2023-10-09T17:38:19.453Z

Ah, yep! This is done internally in aes(), so the only thing that’s needed to accommodate both spellings is export both versions of helper functions like scale_border_color_*() [ though I personally would just direct users to use scale_color_*(aesthetics = "border_color") ]

Brenton Wiernik@bwiernik.bsky.social·2023-10-09T17:39:16.834Z #

Specifically, the standardization is in ggplot2::standardise_aes_names()

Steve Haroz@steveharoz.com·2023-10-10T10:26:40.198Z #

That works for aesthetics but sadly not for static parameters.

Matthew Kay@mjskay.com·2023-10-10T14:01:17.762Z #

Ah yeah. Is there a reason you can't make this an aesthetic?

Steve Haroz@steveharoz.com·2023-10-10T15:20:17.601Z #

I'm not opposed to it in principle, but: 1. Adding scale_bordercolour_* functions would be a big addition to ggplot for an aesthetic that only applies to geom_label. 2. border.color has a "fallback" aesthetic when NULL, as the label will use the text's color aesthetic for the border as a fallback.

Brenton Wiernik@bwiernik.bsky.social·2023-10-10T15:40:10.604Z #

1. I would suggest just leveraging the scale_color_*(aesthetics = "bordercolor") syntax for these niche color aesthetics (the way a lot of extension packages are starting to)

Brenton Wiernik@bwiernik.bsky.social·2023-10-10T15:40:47.722Z #

2. It would be much less frustrating for users if it were a true aesthetic (eg, white vs black border for stat sig, being able to apply stage() for color tweaking for readability). That would be more valuable than a fallback default if both aren’t possible.

Matthew Kay@mjskay.com·2023-10-10T16:45:04.393Z #

Relatedly, does guide_colorbar still complain about being applied to non-standard color aesthetics? That was one problem with using scale_color on them that should be fixed